2.5 KiB
2.5 KiB
PR Description
FIX #xxxx
Checklist (Required)
Before submitting this PR, please ensure that all the following items are completed:
- All code changes pass the
pre-commitchecks. - Commits are signed off using
git commit -s. - The PR title is properly classified (see below).
PR Type
Please prefix the PR title with one or more of the following labels to help reviewers quickly understand the nature of the change:
[Feature]– New features or enhancements (e.g. Attention, Communicator, Kernel, Worker, etc.)[Bugfix]– Bug fixes[CI/Build]– CI, build system, or infrastructure improvements[Doc]– Documentation updates or fixes[Misc]– Other changes that do not fit the above categories (use sparingly)
Note: If the PR spans multiple categories, include all relevant prefixes.
Detailed Checklist (Click to Expand)
Thank you for contributing to vLLM Kunlun! To help us maintain high code quality and streamline the review process, please ensure your PR meets the following requirements.
1. Code Quality
- All linting and formatting checks pass (
pre-commit). - The code is well-structured and sufficiently documented.
- The change is designed with maintainability and readability in mind.
2. Testing
- Relevant unit tests are added or updated.
- Integration tests are included when applicable.
- Existing tests continue to pass.
3. DCO Compliance
This project follows the Developer Certificate of Origin (DCO).
- All commits include a
Signed-off-by:line. - Use
git commit -sto automatically add the sign-off.
4. Review Expectations
During the review process, maintainers may:
- Request code refactoring or additional tests.
- Ask for clarifications on design decisions.
- Suggest performance, stability, or maintainability improvements.
We appreciate your patience and collaboration throughout the review process!