### What this PR does / why we need it?
Fix Qwen MoE accuracy bug in DP scenario.
Now the implentment of `FusedMoE` in vLLM use `All2AllManager` to
manager different all2all algorithm branch. And the default branch use
`Multicast` in `dispatch` phase and `all_reduce` in `combine` phase,
which are not implented in vLLM-Ascend. This leading to invoking into a
default implentment in `base_communicator`, with empty `dispatch` and
`combine` operations, thus causing the accuracy issue on it.
This pr is a temporary workaround, refacting all2all in vLLM-Ascend
could be a better way.
- vLLM version: v0.10.0
- vLLM main:
ad57f23f6a
---------
Signed-off-by: MengqingCao <cmq0113@163.com>
168 lines
5.9 KiB
Python
168 lines
5.9 KiB
Python
#
|
|
# Copyright (c) 2025 Huawei Technologies Co., Ltd. All Rights Reserved.
|
|
# Copyright 2023 The vLLM team.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
# This file is a part of the vllm-ascend project.
|
|
# Adapted from vllm-project/blob/main/tests/entrypoints/llm/test_accuracy.py
|
|
#
|
|
import gc
|
|
import multiprocessing
|
|
import sys
|
|
from multiprocessing import Queue
|
|
|
|
import lm_eval
|
|
import pytest
|
|
import torch
|
|
|
|
SERVER_HOST = "127.0.0.1"
|
|
SERVER_PORT = 8000
|
|
HEALTH_URL = f"http://{SERVER_HOST}:{SERVER_PORT}/health"
|
|
COMPLETIONS_URL = f"http://{SERVER_HOST}:{SERVER_PORT}/v1/completions"
|
|
|
|
# pre-trained model path on Hugging Face.
|
|
# Qwen/Qwen2.5-0.5B-Instruct: accuracy test for DP.
|
|
# Qwen/Qwen3-30B-A3B: accuracy test for EP and DP.
|
|
# deepseek-ai/DeepSeek-V2-Lite: accuracy test for TP.
|
|
MODEL_NAME = ["Qwen/Qwen3-30B-A3B", "deepseek-ai/DeepSeek-V2-Lite"]
|
|
|
|
# Benchmark configuration mapping models to evaluation tasks:
|
|
# - Text model: GSM8K (grade school math reasoning)
|
|
# - Vision-language model: MMMU Art & Design validation (multimodal understanding)
|
|
TASK = {
|
|
"Qwen/Qwen2.5-0.5B-Instruct": "gsm8k",
|
|
"Qwen/Qwen3-30B-A3B": "gsm8k",
|
|
"deepseek-ai/DeepSeek-V2-Lite": "gsm8k"
|
|
}
|
|
# Answer validation requiring format consistency.
|
|
FILTER = {
|
|
"Qwen/Qwen2.5-0.5B-Instruct": "exact_match,strict-match",
|
|
"Qwen/Qwen3-30B-A3B": "exact_match,strict-match",
|
|
"deepseek-ai/DeepSeek-V2-Lite": "exact_match,strict-match"
|
|
}
|
|
# 3% relative tolerance for numerical accuracy.
|
|
RTOL = 0.03
|
|
# Baseline accuracy after VLLM optimization.
|
|
EXPECTED_VALUE = {
|
|
"Qwen/Qwen2.5-0.5B-Instruct": 0.316,
|
|
"Qwen/Qwen3-30B-A3B": 0.888,
|
|
"deepseek-ai/DeepSeek-V2-Lite": 0.375
|
|
}
|
|
# Maximum context length configuration for each model.
|
|
MAX_MODEL_LEN = {
|
|
"Qwen/Qwen2.5-0.5B-Instruct": 4096,
|
|
"Qwen/Qwen3-30B-A3B": 4096,
|
|
"deepseek-ai/DeepSeek-V2-Lite": 4096
|
|
}
|
|
# Model types distinguishing text-only and vision-language models.
|
|
MODEL_TYPE = {
|
|
"Qwen/Qwen2.5-0.5B-Instruct": "vllm",
|
|
"Qwen/Qwen3-30B-A3B": "vllm",
|
|
"deepseek-ai/DeepSeek-V2-Lite": "vllm"
|
|
}
|
|
# wrap prompts in a chat-style template.
|
|
APPLY_CHAT_TEMPLATE = {
|
|
"Qwen/Qwen2.5-0.5B-Instruct": False,
|
|
"Qwen/Qwen3-30B-A3B": False,
|
|
"deepseek-ai/DeepSeek-V2-Lite": False
|
|
}
|
|
# Few-shot examples handling as multi-turn dialogues.
|
|
FEWSHOT_AS_MULTITURN = {
|
|
"Qwen/Qwen2.5-0.5B-Instruct": False,
|
|
"Qwen/Qwen3-30B-A3B": False,
|
|
"deepseek-ai/DeepSeek-V2-Lite": False
|
|
}
|
|
# MORE_ARGS extra CLI args per model
|
|
MORE_ARGS = {
|
|
"Qwen/Qwen2.5-0.5B-Instruct":
|
|
None,
|
|
"Qwen/Qwen3-30B-A3B":
|
|
"tensor_parallel_size=2,enable_expert_parallel=True,enforce_eager=True",
|
|
"deepseek-ai/DeepSeek-V2-Lite":
|
|
"tensor_parallel_size=2,trust_remote_code=True,enforce_eager=True"
|
|
}
|
|
|
|
multiprocessing.set_start_method("spawn", force=True)
|
|
|
|
|
|
def run_test(queue, model, max_model_len, model_type, more_args):
|
|
try:
|
|
if model_type == "vllm-vlm":
|
|
model_args = (f"pretrained={model},max_model_len={max_model_len},"
|
|
"dtype=auto,max_images=2")
|
|
else:
|
|
model_args = (f"pretrained={model},max_model_len={max_model_len},"
|
|
"dtype=auto")
|
|
if more_args is not None:
|
|
model_args = f"{model_args},{more_args}"
|
|
results = lm_eval.simple_evaluate(
|
|
model=model_type,
|
|
model_args=model_args,
|
|
tasks=TASK[model],
|
|
batch_size="auto",
|
|
apply_chat_template=APPLY_CHAT_TEMPLATE[model],
|
|
fewshot_as_multiturn=FEWSHOT_AS_MULTITURN[model],
|
|
)
|
|
result = results["results"][TASK[model]][FILTER[model]]
|
|
print("result:", result)
|
|
queue.put(result)
|
|
except Exception as e:
|
|
error_msg = f"{type(e).__name__}: {str(e)}"
|
|
queue.put(error_msg)
|
|
sys.exit(1)
|
|
finally:
|
|
gc.collect()
|
|
torch.npu.empty_cache()
|
|
|
|
|
|
@pytest.mark.parametrize("model", MODEL_NAME)
|
|
def test_lm_eval_accuracy(monkeypatch: pytest.MonkeyPatch, model):
|
|
with monkeypatch.context():
|
|
result_queue: Queue[float] = multiprocessing.Queue()
|
|
p = multiprocessing.Process(target=run_test,
|
|
args=(result_queue, model,
|
|
MAX_MODEL_LEN[model],
|
|
MODEL_TYPE[model], MORE_ARGS[model]))
|
|
p.start()
|
|
p.join()
|
|
result = result_queue.get()
|
|
print(result)
|
|
assert (EXPECTED_VALUE[model] - RTOL < result < EXPECTED_VALUE[model] + RTOL), \
|
|
f"Expected: {EXPECTED_VALUE[model]}±{RTOL} | Measured: {result}"
|
|
|
|
|
|
DP_DENSCE_MODEL = ["Qwen/Qwen2.5-0.5B-Instruct"]
|
|
DP_MOE_MOEDL = ["Qwen/Qwen3-30B-A3B"]
|
|
|
|
DP_MORE_ARGS = {
|
|
"Qwen/Qwen2.5-0.5B-Instruct":
|
|
"tensor_parallel_size=2,data_parallel_size=2",
|
|
"Qwen/Qwen3-30B-A3B":
|
|
"tensor_parallel_size=2,data_parallel_size=2,enable_expert_parallel=True,max_model_len=1024,enforce_eager=True",
|
|
}
|
|
|
|
|
|
@pytest.mark.parametrize("model", DP_DENSCE_MODEL)
|
|
def test_lm_eval_accuracy_dp(model):
|
|
result_queue: Queue[float] = multiprocessing.Queue()
|
|
p = multiprocessing.Process(target=run_test,
|
|
args=(result_queue, model,
|
|
MAX_MODEL_LEN[model], MODEL_TYPE[model],
|
|
DP_MORE_ARGS[model]))
|
|
p.start()
|
|
p.join()
|
|
result = result_queue.get()
|
|
print(result)
|
|
assert (EXPECTED_VALUE[model] - RTOL < result < EXPECTED_VALUE[model] + RTOL), \
|
|
f"Expected: {EXPECTED_VALUE[model]}±{RTOL} | Measured: {result}"
|