52086394ae
### What this PR does / why we need it?
Convert `vllm-ascend/compilation` to ruff format.
### Does this PR introduce _any_ user-facing change?
During this migration, we encountered some **errors** in our CI and
testing environments, such as:
```
vllm_ascend/utils.py:653: in <module>
def register_ascend_customop(vllm_config: VllmConfig | None = None):
^^^^^^^^^^^^^^^^^
E TypeError: unsupported operand type(s) for |: 'NoneType' and 'NoneType'
```
**1. Root Cause Analysis:**
The project uses a common pattern to break circular dependencies:
```python
if TYPE_CHECKING:
from vllm.config import VllmConfig
else:
VllmConfig = None # Placeholder assigned at runtime
```
When Python parses the function definition `def
register_ascend_customop(vllm_config: VllmConfig | None)`, it attempts
to evaluate the expression `VllmConfig | None`.
Since `VllmConfig` is assigned `None` at runtime, the expression
effectively becomes `None | None`. In Python, `None` is an instance of
`NoneType`. While the `|` operator is implemented for Type objects
(classes), it is not supported for `NoneType` instances, leading to the
`TypeError` shown above.
**2. Solution:**
To maintain the modern `|` syntax required by our new linting standards
while preserving our dependency management strategy, I have introduced:
```python
from __future__ import annotations
```
at the top of the affected files. This enables **Postponed Evaluation of
Annotations (PEP 563)**.
**3. Impact and Benefits:**
- By enabling `annotations`, Python no longer executes the `VllmConfig |
None` operation during module load. Instead, it stores the annotation as
a string literal, completely avoiding the `None | None` calculation.
- We can keep the `VllmConfig = None` placeholders. This ensures that
other modules can still import these symbols without triggering an
`ImportError`, maintaining a stable dependency graph.
- IDEs and static type checkers (MyPy/Pyright) continue to resolve the
types correctly. This allows us to use modern syntax without sacrificing
type safety or runtime stability.
- The only side effect is that `__annotations__` will now return strings
instead of type objects. Since this module does not use runtime type
enforcement or reflection, this change has zero negative impact on
existing functionality.
### How was this patch tested?
- vLLM version: v0.13.0
- vLLM main:
11b6af5280
---------
Signed-off-by: MrZ20 <2609716663@qq.com>
110 lines
2.4 KiB
TOML
110 lines
2.4 KiB
TOML
[build-system]
|
|
# Should be mirrored in requirements.txt
|
|
requires = [
|
|
"attrs",
|
|
"cmake>=3.26",
|
|
"decorator",
|
|
"einops",
|
|
"googleapis-common-protos",
|
|
"numpy<2.0.0",
|
|
"packaging",
|
|
"pip",
|
|
"pybind11",
|
|
"pyyaml",
|
|
"scipy",
|
|
"pandas",
|
|
"pandas-stubs",
|
|
"psutil",
|
|
"setuptools>=64",
|
|
"setuptools-scm>=8",
|
|
"transformers<=4.57.1",
|
|
"torch-npu==2.8.0",
|
|
"torch==2.8.0",
|
|
"torchvision",
|
|
"wheel",
|
|
"msgpack",
|
|
"quart",
|
|
"numba",
|
|
"fastapi<0.124.0",
|
|
"opencv-python-headless<=4.11.0.86", # Required to avoid numpy version conflict with vllm
|
|
"compressed_tensors>=0.11.0",
|
|
"arctic-inference==0.1.1"
|
|
]
|
|
build-backend = "setuptools.build_meta"
|
|
|
|
[tool.pymarkdown]
|
|
plugins.md004.style = "sublist" # ul-style
|
|
plugins.md007.indent = 4 # ul-indent
|
|
plugins.md007.start_indented = true # ul-indent
|
|
plugins.md013.enabled = false # line-length
|
|
plugins.md041.enabled = false # first-line-h1
|
|
plugins.md033.enabled = false # inline-html
|
|
plugins.md046.enabled = false # code-block-style
|
|
plugins.md024.allow_different_nesting = true # no-duplicate-headers
|
|
plugins.md029.enabled = false # ol-prefix
|
|
|
|
[tool.ruff]
|
|
# TODO: according to PEP8, there should be 80 characters per line
|
|
line-length = 120
|
|
# Folder to be modified
|
|
exclude = [
|
|
"tests/**",
|
|
"vllm_ascend/_cann_ops_custom",
|
|
"vllm_ascend/attention",
|
|
"vllm_ascend/core",
|
|
"vllm_ascend/device",
|
|
"vllm_ascend/device_allocator",
|
|
"vllm_ascend/distributed",
|
|
"vllm_ascend/eplb",
|
|
"vllm_ascend/kv_offload",
|
|
"vllm_ascend/lora",
|
|
"vllm_ascend/model_loader",
|
|
"vllm_ascend/ops",
|
|
"vllm_ascend/patch",
|
|
"vllm_ascend/quantization",
|
|
"vllm_ascend/sample",
|
|
"vllm_ascend/spec_decode",
|
|
"vllm_ascend/worker",
|
|
"vllm_ascend/xlite",
|
|
"vllm_ascend/envs.py",
|
|
"vllm_ascend/batch_invariant.py",
|
|
]
|
|
|
|
[tool.ruff.lint]
|
|
select = [
|
|
# pycodestyle
|
|
"E",
|
|
# Pyflakes
|
|
"F",
|
|
# pyupgrade
|
|
"UP",
|
|
# flake8-bugbear
|
|
"B",
|
|
# flake8-simplify
|
|
"SIM",
|
|
# isort
|
|
"I",
|
|
# flake8-logging-format
|
|
"G",
|
|
]
|
|
ignore = [
|
|
# star imports
|
|
"F405", "F403",
|
|
# lambda expression assignment
|
|
"E731",
|
|
# zip without `strict=`
|
|
"B905",
|
|
# Loop control variable not used within loop body
|
|
"B007",
|
|
# f-string format
|
|
"UP032",
|
|
# TODO: FIE ME
|
|
"G004",
|
|
"B904",
|
|
"SIM108",
|
|
"SIM102"
|
|
]
|
|
|
|
[tool.ruff.format]
|
|
docstring-code-format = true
|