From f39365d2ea1e03fde09c9f3debde529010b7b9e7 Mon Sep 17 00:00:00 2001 From: Li Wang Date: Wed, 2 Jul 2025 14:06:08 +0800 Subject: [PATCH] [Benchmark] Fix error msg upload in performance benchmark (#1559) ### What this PR does / why we need it? Make sure that None parameters are not passed in for `--error` ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed locally Signed-off-by: wangli --- .github/workflows/nightly_benchmarks.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/nightly_benchmarks.yaml b/.github/workflows/nightly_benchmarks.yaml index 109f0d8..c419ac6 100644 --- a/.github/workflows/nightly_benchmarks.yaml +++ b/.github/workflows/nightly_benchmarks.yaml @@ -198,7 +198,7 @@ jobs: --commit_title "$commit_title" \ --created_at "$commit_time_no_tz" \ --res_dir ./benchmarks/results \ - --error $ERROR_MSG \ + --error "$ERROR_MSG" \ --extra_feat '{"VLLM_USE_V1": "${{ matrix.vllm_use_v1 }}"}' rm -rf ./benchmarks/results cd -