EngineX/xc-llm-ascend
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[CI] Fix nightly benchmark (#1453)

Browse Source 
### What this PR does / why we need it?
Sometimes the performance benchmark workflow may fail. We hope to add a
prompt when the operation fails and not upload the dirty data of the
failed operation.

---------

Signed-off-by: wangli <wangli858794774@gmail.com>
This commit is contained in:
Li Wang
2025-06-26 19:39:18 +08:00
committed by GitHub
parent 192dbbcc6e
commit c563a08f0a
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
.github/workflows/nightly_benchmarks.yaml vendored
View File

@@ -145,8 +145,8 @@ jobs:
- name: Install elastic_tool - name: Install elastic_tool
if: github.event_name != 'pull_request' if: github.event_name != 'pull_request'
run: | run: |
pip install escli-tool==0.2.2 pip install escli-tool==0.2.3
- name: Collect pr info from vllm-project/vllm-ascend - name: Collect pr info from vllm-project/vllm-ascend
if: github.event_name != 'pull_request' if: github.event_name != 'pull_request'
run: | run: |
@@ -176,7 +176,7 @@ jobs:
commit_time=$(git show -s --format=%cd $commit_hash --date=iso-strict) commit_time=$(git show -s --format=%cd $commit_hash --date=iso-strict)
commit_time_no_tz=${commit_time::19} commit_time_no_tz=${commit_time::19}
pip install -e . pip install -e .
echo "------------------------" echo "------------------------"
echo "commit_id: $commit_id" echo "commit_id: $commit_id"
echo "commit_title: $commit_title" echo "commit_title: $commit_title"
@@ -184,9 +184,12 @@ jobs:
echo "vllm branch: ${{ matrix.vllm_branch }}" echo "vllm branch: ${{ matrix.vllm_branch }}"
echo "vllm-ascend branch: ${{ matrix.vllm_ascend_branch }}" echo "vllm-ascend branch: ${{ matrix.vllm_ascend_branch }}"
echo "------------------------" echo "------------------------"
cd /github/home cd /github/home
bash benchmarks/scripts/run-performance-benchmarks.sh ERROR_MSG=""
if ! bash benchmarks/scripts/run-performance-benchmarks.sh; then
ERROR_MSG="Benchmark failed to run"
fi
# send the result to es # send the result to es
escli add --vllm_branch ${{ matrix.vllm_branch }} \ escli add --vllm_branch ${{ matrix.vllm_branch }} \
--vllm_ascend_branch ${{ matrix.vllm_ascend_branch }} \ --vllm_ascend_branch ${{ matrix.vllm_ascend_branch }} \
@@ -194,6 +197,7 @@ jobs:
--commit_title "$commit_title" \ --commit_title "$commit_title" \
--created_at "$commit_time_no_tz" \ --created_at "$commit_time_no_tz" \
--res_dir ./benchmarks/results \ --res_dir ./benchmarks/results \
--error $ERROR_MSG \
--extra_feat '{"VLLM_USE_V1": "${{ matrix.vllm_use_v1 }}"}' --extra_feat '{"VLLM_USE_V1": "${{ matrix.vllm_use_v1 }}"}'
rm -rf ./benchmarks/results rm -rf ./benchmarks/results
cd - cd -

2
benchmarks/scripts/run-performance-benchmarks.sh
View File

@@ -1,5 +1,5 @@
#!/bin/bash #!/bin/bash
set -e
check_npus() { check_npus() {
# shellcheck disable=SC2155 # shellcheck disable=SC2155