From acb46f303fee6257575da442b8143eafb29df932 Mon Sep 17 00:00:00 2001 From: Icey <1790571317@qq.com> Date: Thu, 18 Sep 2025 19:54:01 +0800 Subject: [PATCH] Fix VocabParallelEmbedding UT (#2722) ### What this PR does / why we need it? Fix VocabParallelEmbedding UT ### How was this patch tested? CI passed with new added/existing test. - vLLM version: main - vLLM main: https://github.com/vllm-project/vllm/commit/f592b3174b39a7aeac52432d66d76e89ff0a80b4 --------- Signed-off-by: Icey <1790571317@qq.com> --- .github/workflows/vllm_ascend_test.yaml | 2 +- tests/ut/ops/test_vocab_parallel_embedding.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/vllm_ascend_test.yaml b/.github/workflows/vllm_ascend_test.yaml index 1a342d2..04f589e 100644 --- a/.github/workflows/vllm_ascend_test.yaml +++ b/.github/workflows/vllm_ascend_test.yaml @@ -118,7 +118,7 @@ jobs: TORCH_DEVICE_BACKEND_AUTOLOAD: 0 run: | export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:/usr/local/Ascend/ascend-toolkit/latest/x86_64-linux/devlib - pytest -sv --cov --cov-report=xml:unittests-coverage.xml tests/ut --ignore=tests/ut/test_platform.py --ignore=tests/ut/ops/test_vocab_parallel_embedding.py + pytest -sv --cov --cov-report=xml:unittests-coverage.xml tests/ut --ignore=tests/ut/test_platform.py - name: Upload coverage to Codecov if: ${{ matrix.vllm_version == 'main' }} diff --git a/tests/ut/ops/test_vocab_parallel_embedding.py b/tests/ut/ops/test_vocab_parallel_embedding.py index 66163f5..d137985 100644 --- a/tests/ut/ops/test_vocab_parallel_embedding.py +++ b/tests/ut/ops/test_vocab_parallel_embedding.py @@ -18,6 +18,7 @@ from unittest.mock import MagicMock, patch import torch +from vllm_ascend.ascend_config import init_ascend_config from vllm_ascend.ops.vocab_parallel_embedding import ( AscendLogitsProcessor, AscendParallelLMHead, AscendVocabParallelEmbedding) @@ -31,6 +32,9 @@ class TestCustomVocabParallelEmbedding(unittest.TestCase): self.embedding_dim = 10 self.org_num_embeddings = 40 self.padding_size = 8 + mock_vllm_config = MagicMock() + mock_vllm_config.additional_config = {} + init_ascend_config(mock_vllm_config) def _create_layer(self): # Patch methods and dependencies for VocabParallelEmbedding