EngineX/xc-llm-ascend
3
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use ci_vllm_version when recording vLLM commit (#1689)

Browse Source 
### What this PR does / why we need it?
Use ci_vllm_version when recording vllm commit

Followup on https://github.com/vllm-project/vllm-ascend/pull/1623

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
- Test mannually.
$ python3 docs/source/conf.py | jq .ci_vllm_version | tr -d '"'
v0.9.2
- Test on my local repo: https://github.com/Yikun/vllm-ascend/pull/35

- vLLM version: v0.9.1
- vLLM main:
49e8c7ea25

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
This commit is contained in:
Yikun Jiang
2025-07-10 11:07:27 +08:00
committed by GitHub
parent 89c1a0f006
commit 997f156a51
3 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
.github/format_pr_body.sh vendored
View File

@@ -13,7 +13,7 @@
# See the License for the specific language governing permissions and # See the License for the specific language governing permissions and
# limitations under the License. # limitations under the License.
# This file is a part of the vllm-ascend project. # This file is a part of the vllm-ascend project.
# # Adapted from vllm/.github/scripts/cleanup_pr_body.sh
#!/bin/bash #!/bin/bash
@@ -34,11 +34,15 @@ NEW=/tmp/new_pr_body.txt
gh pr view --json body --template "{{.body}}" "${PR_NUMBER}" > "${OLD}" gh pr view --json body --template "{{.body}}" "${PR_NUMBER}" > "${OLD}"
cp "${OLD}" "${NEW}" cp "${OLD}" "${NEW}"
# Remove "FIX #xxxx (*link existing issues this PR will resolve*)" # Remove notes in pr description and add vLLM version and commit
sed -i '/<!--/,/-->/d' "${NEW}" sed -i '/<!--/,/-->/d' "${NEW}"
sed -i '/- vLLM .*$/d' "${NEW}" sed -i '/- vLLM .*$/d' "${NEW}"
echo "- vLLM version: $VLLM_VERSION" >> "${NEW}" {
echo "- vLLM main: $VLLM_COMMIT" >> "${NEW}" echo ""
echo "- vLLM version: $VLLM_VERSION"
echo "- vLLM main: $VLLM_COMMIT"
echo ""
} >> "${NEW}"
# Run this only if ${NEW} is different than ${OLD} # Run this only if ${NEW} is different than ${OLD}
if ! cmp -s "${OLD}" "${NEW}"; then if ! cmp -s "${OLD}" "${NEW}"; then

2
.github/workflows/format_pr_body.yaml vendored
View File

@@ -53,7 +53,7 @@ jobs:
- name: Get vLLM release version - name: Get vLLM release version
run: | run: |
VLLM_VERSION=$(python3 docs/source/conf.py | jq .vllm_version | tr -d '"') VLLM_VERSION=$(python3 docs/source/conf.py | jq .ci_vllm_version | tr -d '"')
echo "VLLM_VERSION=$VLLM_VERSION" >> $GITHUB_ENV echo "VLLM_VERSION=$VLLM_VERSION" >> $GITHUB_ENV
- name: Update PR description - name: Update PR description

2
docs/source/conf.py
View File

@@ -76,6 +76,8 @@ myst_substitutions = {
'pip_vllm_version': "0.9.1", 'pip_vllm_version': "0.9.1",
# CANN image tag # CANN image tag
'cann_image_tag': "8.1.rc1-910b-ubuntu22.04-py3.10", 'cann_image_tag': "8.1.rc1-910b-ubuntu22.04-py3.10",
# vllm version in ci
'ci_vllm_version': 'v0.9.2',
} }
# Add any paths that contain templates here, relative to this directory. # Add any paths that contain templates here, relative to this directory.