From 4495fc68389e3fb1ef14534c202948931e38446b Mon Sep 17 00:00:00 2001 From: zouyida2002 Date: Fri, 7 Feb 2025 16:46:24 +0800 Subject: [PATCH] bugfix for mrope (#14) a fix follow up [MRotaryEmbedding change](https://github.com/vllm-project/vllm/commit/bf3b79efb82676219a3275764d8fcf4c70097ce5#diff-6bc44986c91bf0876240dec03d56c748403691c7fcd90f7a22e7affff7b033ecR839) Signed-off-by: z00897138 Co-authored-by: z00897138 --- vllm_ascend/model_runner.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/vllm_ascend/model_runner.py b/vllm_ascend/model_runner.py index 417c669..77e093b 100644 --- a/vllm_ascend/model_runner.py +++ b/vllm_ascend/model_runner.py @@ -749,14 +749,10 @@ class ModelInputForNPUBuilder(ModelRunnerInputBuilderBase[ModelInputForNPU]): mrope_input_positions, mrope_position_delta = \ MRotaryEmbedding.get_input_positions( token_ids, + hf_config, image_grid_thw=image_grid_thw, video_grid_thw=video_grid_thw, - image_token_id=hf_config.image_token_id, - video_token_id=hf_config.video_token_id, - vision_start_token_id=hf_config.vision_start_token_id, - vision_end_token_id=hf_config.vision_end_token_id, - spatial_merge_size=hf_config.vision_config. - spatial_merge_size, + second_per_grid_ts=None, context_len=inter_data.context_lens[seq_idx], seq_len=inter_data.seq_lens[seq_idx], )