From 28d769136146fa6e596b0e95abfb000402e45fa7 Mon Sep 17 00:00:00 2001 From: Yikun Jiang Date: Wed, 12 Feb 2025 09:17:05 +0800 Subject: [PATCH] [FOLLOWUP][Misc] Remove unused mypy config for base_communicator (#45) ### What this PR does / why we need it? - Remove on communicator mypy to address: https://github.com/vllm-project/vllm-ascend/pull/24#issuecomment-2647696781 - Add mypy.ini to trigger list ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang --- .github/workflows/mypy.yaml | 2 ++ mypy.ini | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/mypy.yaml b/.github/workflows/mypy.yaml index ec9c2e6..b23178b 100644 --- a/.github/workflows/mypy.yaml +++ b/.github/workflows/mypy.yaml @@ -27,6 +27,7 @@ on: - '**/*.py' - '.github/workflows/mypy.yaml' - 'tools/mypy.sh' + - 'mypy.ini' pull_request: branches: - "main" @@ -39,6 +40,7 @@ on: - '**/*.py' - '.github/workflows/mypy.yaml' - 'tools/mypy.sh' + - 'mypy.ini' jobs: mypy: diff --git a/mypy.ini b/mypy.ini index b627e7f..8d24259 100644 --- a/mypy.ini +++ b/mypy.ini @@ -9,6 +9,3 @@ ignore_missing_imports = True [mypy-transformers.*] ignore_missing_imports = True -; Remove this after https://github.com/vllm-project/vllm/pull/11324 merged -[mypy-vllm.distributed.device_communicators.base_communicator] -ignore_missing_imports = True