From b4f1006864a7e86576be105d03541ba4eaaaf00e Mon Sep 17 00:00:00 2001 From: Fangjun Kuang Date: Tue, 28 May 2024 18:46:43 +0800 Subject: [PATCH] fix node-addaon-api for vad (#932) --- .github/scripts/node-addon/run.sh | 2 +- .github/workflows/npm-addon.yaml | 2 +- scripts/node-addon-api/src/vad.cc | 4 ++-- scripts/node-addon-api/src/wave-writer.cc | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/scripts/node-addon/run.sh b/.github/scripts/node-addon/run.sh index 19c98abe..0adf240f 100755 --- a/.github/scripts/node-addon/run.sh +++ b/.github/scripts/node-addon/run.sh @@ -18,7 +18,7 @@ fi SHERPA_ONNX_VERSION=$(grep "SHERPA_ONNX_VERSION" ./CMakeLists.txt | cut -d " " -f 2 | cut -d '"' -f 2) echo "SHERPA_ONNX_VERSION $SHERPA_ONNX_VERSION" -# SHERPA_ONNX_VERSION=1.0.27 +# SHERPA_ONNX_VERSION=1.0.28 if [ -z $owner ]; then owner=k2-fsa diff --git a/.github/workflows/npm-addon.yaml b/.github/workflows/npm-addon.yaml index 05642233..73e8c05e 100644 --- a/.github/workflows/npm-addon.yaml +++ b/.github/workflows/npm-addon.yaml @@ -55,7 +55,7 @@ jobs: SHERPA_ONNX_VERSION=$(grep "SHERPA_ONNX_VERSION" ./CMakeLists.txt | cut -d " " -f 2 | cut -d '"' -f 2) echo "SHERPA_ONNX_VERSION $SHERPA_ONNX_VERSION" - # SHERPA_ONNX_VERSION=1.0.27 + # SHERPA_ONNX_VERSION=1.0.28 src_dir=.github/scripts/node-addon sed -i.bak s/SHERPA_ONNX_VERSION/$SHERPA_ONNX_VERSION/g $src_dir/package.json diff --git a/scripts/node-addon-api/src/vad.cc b/scripts/node-addon-api/src/vad.cc index 217033c9..edebe291 100644 --- a/scripts/node-addon-api/src/vad.cc +++ b/scripts/node-addon-api/src/vad.cc @@ -137,8 +137,8 @@ static Napi::Float32Array CircularBufferGetWrapper( return float32Array; } else { // don't use external buffer - Napi::ArrayBuffer arrayBuffer = Napi::ArrayBuffer::New( - env, const_cast(data), sizeof(float) * n); + Napi::ArrayBuffer arrayBuffer = + Napi::ArrayBuffer::New(env, sizeof(float) * n); Napi::Float32Array float32Array = Napi::Float32Array::New(env, n, arrayBuffer, 0); diff --git a/scripts/node-addon-api/src/wave-writer.cc b/scripts/node-addon-api/src/wave-writer.cc index 28ee71a2..3ade695a 100644 --- a/scripts/node-addon-api/src/wave-writer.cc +++ b/scripts/node-addon-api/src/wave-writer.cc @@ -13,7 +13,7 @@ static Napi::Boolean WriteWaveWrapper(const Napi::CallbackInfo &info) { if (info.Length() != 2) { std::ostringstream os; - os << "Expect only 2 argument2. Given: " << info.Length(); + os << "Expect only 2 arguments. Given: " << info.Length(); Napi::TypeError::New(env, os.str()).ThrowAsJavaScriptException();