[PD] support spec decode (#6507)

Co-authored-by: SangBin Cho <rkooo567@gmail.com>

test/srt/run_suite.py

@@ -115,7 +115,7 @@ suites = {
         # TestFile("test_deepep_intranode.py", 50),
         # TestFile("test_deepep_low_latency.py", 50),
         # TestFile("test_moe_deepep_eval_accuracy_large.py", 250),
-        # TestFile("test_disaggregation.py", 210), # disabled since we have different_tp test
+        TestFile("test_disaggregation.py", 210),
         TestFile("test_disaggregation_different_tp.py", 210),
         TestFile("test_full_deepseek_v3.py", 250),
     ],

test/srt/test_disaggregation.py

@@ -8,6 +8,8 @@ import requests
 from sglang.srt.utils import kill_process_tree
 from sglang.test.few_shot_gsm8k import run_eval as run_eval_few_shot_gsm8k
 from sglang.test.test_utils import (
+    DEFAULT_EAGLE_DRAFT_MODEL_FOR_TEST,
+    DEFAULT_EAGLE_TARGET_MODEL_FOR_TEST,
     DEFAULT_MODEL_NAME_FOR_TEST,
     DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
     DEFAULT_URL_FOR_TEST,
@@ -17,7 +19,9 @@ from sglang.test.test_utils import (
 )
 
 
-class TestDisaggregationMooncake(CustomTestCase):
+# skip the test because we have different_tp test
+@unittest.skip("skip the test because we have different_tp test")
+class TestDisaggregationAccuracy(CustomTestCase):
     @classmethod
     def setUpClass(cls):
         cls.model = DEFAULT_MODEL_NAME_FOR_TEST
@@ -65,6 +69,8 @@ class TestDisaggregationMooncake(CustomTestCase):
             str(cls.base_port + 100),
             "--tp",
             "4",
+            # "--disaggregation-ib-device",
+            # "mlx5_roce0,mlx5_roce1,mlx5_roce2,mlx5_roce3",
         ]
         cls.process_prefill = popen_launch_pd_server(
             cls.model,
@@ -87,6 +93,8 @@ class TestDisaggregationMooncake(CustomTestCase):
             "4",
             "--base-gpu-id",
             "4",
+            # "--disaggregation-ib-device",
+            # "mlx5_roce4,mlx5_roce5,mlx5_roce6,mlx5_roce7",
         ]
         cls.process_decode = popen_launch_pd_server(
             cls.model,
@@ -136,5 +144,138 @@ class TestDisaggregationMooncake(CustomTestCase):
         self.assertGreater(metrics["accuracy"], 0.62)
 
 
+class TestDisaggregationSpecAccuracy(CustomTestCase):
+
+    @classmethod
+    def setUpClass(cls):
+        super().setUpClass()
+        cls.model = DEFAULT_EAGLE_TARGET_MODEL_FOR_TEST
+        cls.draft_model = DEFAULT_EAGLE_DRAFT_MODEL_FOR_TEST
+        cls.base_host = "127.0.0.1"
+        cls.base_port = int(DEFAULT_URL_FOR_TEST.split(":")[-1])
+        cls.lb_url = DEFAULT_URL_FOR_TEST
+        cls.prefill_url = f"http://{cls.base_host}:{cls.base_port + 100}"
+        cls.decode_url = f"http://{cls.base_host}:{cls.base_port + 200}"
+        cls.spec_args = [
+            "--speculative-algorithm",
+            "EAGLE",
+            "--speculative-draft-model-path",
+            cls.draft_model,
+            "--speculative-num-steps",
+            "3",
+            "--speculative-eagle-topk",
+            "4",
+            "--speculative-num-draft-tokens",
+            "16",
+            "--cuda-graph-max-bs",
+            "8",
+        ]
+
+        run_with_timeout(cls.start_prefill, timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH)
+        run_with_timeout(cls.start_decode, timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH)
+
+        cls.wait_server_ready(cls.prefill_url + "/health")
+        cls.wait_server_ready(cls.decode_url + "/health")
+
+        lb_command = [
+            "python3",
+            "-m",
+            "sglang.srt.disaggregation.mini_lb",
+            "--prefill",
+            cls.prefill_url,
+            "--decode",
+            cls.decode_url,
+            "--host",
+            cls.base_host,
+            "--port",
+            str(cls.base_port),
+        ]
+
+        print("Starting load balancer:", " ".join(lb_command))
+        cls.process_lb = subprocess.Popen(
+            lb_command, stdout=subprocess.PIPE, stderr=subprocess.PIPE
+        )
+        cls.wait_server_ready(cls.lb_url + "/health")
+
+    @classmethod
+    def wait_server_ready(cls, url, timeout=60):
+        start_time = time.perf_counter()
+        while True:
+            try:
+                response = requests.get(url)
+                if response.status_code == 200:
+                    print(f"Server {url} is ready")
+                    return
+            except Exception:
+                pass
+
+            if time.perf_counter() - start_time > timeout:
+                raise RuntimeError(f"Server {url} failed to start in {timeout}s")
+            time.sleep(1)
+
+    @classmethod
+    def start_prefill(cls):
+
+        prefill_args = [
+            "--trust-remote-code",
+            "--disaggregation-mode",
+            "prefill",
+            "--host",
+            cls.base_host,
+            "--port",
+            str(cls.base_port + 100),
+            "--tp",
+            "4",
+            # "--disaggregation-ib-device",
+            # "mlx5_roce0,mlx5_roce1,mlx5_roce2,mlx5_roce3",
+        ] + cls.spec_args
+
+        cls.process_prefill = popen_launch_pd_server(
+            cls.model,
+            cls.prefill_url,
+            timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
+            other_args=prefill_args,
+        )
+
+    @classmethod
+    def start_decode(cls):
+        decode_args = [
+            "--trust-remote-code",
+            "--disaggregation-mode",
+            "decode",
+            "--host",
+            cls.base_host,
+            "--port",
+            str(cls.base_port + 200),
+            "--tp",
+            "4",
+            "--base-gpu-id",
+            "4",
+            # "--disaggregation-ib-device",
+            # "mlx5_roce4,mlx5_roce5,mlx5_roce6,mlx5_roce7",
+        ] + cls.spec_args
+        cls.process_decode = popen_launch_pd_server(
+            cls.model,
+            cls.decode_url,
+            timeout=DEFAULT_TIMEOUT_FOR_SERVER_LAUNCH,
+            other_args=decode_args,
+        )
+
+    def test_gsm8k(self):
+        args = SimpleNamespace(
+            num_shots=5,
+            data_path=None,
+            num_questions=200,
+            max_new_tokens=512,
+            parallel=4,  # TODO: 128 crashes the decode
+            host="http://127.0.0.1",
+            port=int(self.lb_url.split(":")[-1]),
+        )
+        metrics = run_eval_few_shot_gsm8k(args)
+        print(f"Evaluation metrics: {metrics}")
+
+        self.assertGreater(metrics["accuracy"], 0.20)
+
+
 if __name__ == "__main__":
     unittest.main()