From b1ccaf01cd59cdf8c0fa35c04a51555ed537a670 Mon Sep 17 00:00:00 2001 From: fzyzcjy <5236035+fzyzcjy@users.noreply.github.com> Date: Thu, 2 Oct 2025 17:55:01 +0800 Subject: [PATCH] Tiny improve dumper (#11132) --- python/sglang/srt/debug_utils/dumper.py | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/python/sglang/srt/debug_utils/dumper.py b/python/sglang/srt/debug_utils/dumper.py index 8a9808bb7..1730ed98f 100644 --- a/python/sglang/srt/debug_utils/dumper.py +++ b/python/sglang/srt/debug_utils/dumper.py @@ -36,6 +36,15 @@ class _Dumper: self._forward_pass_id = 0 def on_forward_pass_start(self): + """This should be called on all ranks.""" + + if not self._enable: + return + + # Users may want to `dump` only on some ranks, thus determine name here + if self._partial_name is None: + self._partial_name = _get_partial_name() + self._forward_pass_id += 1 print( f"[Dumper] [{time.time()}] on_forward_pass_start id={self._forward_pass_id}" @@ -48,11 +57,9 @@ class _Dumper: assert ( self._forward_pass_id >= 1 ), "Do you forget to call `dumper.on_forward_pass_start()`?" + assert self._partial_name is not None self._dump_index += 1 - if self._partial_name is None: - self._partial_name = _get_partial_name() - rank = _get_rank() full_kwargs = dict( forward_pass_id=self._forward_pass_id,