From 9bddf1c82d37c7edd3964253cbaa38d24b23fda4 Mon Sep 17 00:00:00 2001
From: Cheng Wan <54331508+ch-wan@users.noreply.github.com>
Date: Wed, 7 May 2025 21:49:58 -0400
Subject: [PATCH] Deferring 8 GPU test (#6102)

---
 .github/workflows/pr-test.yml   | 47 +++++++++++++++++++--------------
 test/srt/test_pp_single_node.py |  2 +-
 2 files changed, 28 insertions(+), 21 deletions(-)

diff --git a/.github/workflows/pr-test.yml b/.github/workflows/pr-test.yml
index a1c9d6011..fb62ac488 100644
--- a/.github/workflows/pr-test.yml
+++ b/.github/workflows/pr-test.yml
@@ -7,12 +7,14 @@ on:
       - "python/**"
       - "scripts/**"
       - "test/**"
+      - ".github/workflows/pr-test.yml"
   pull_request:
     branches: [ main ]
     paths:
       - "python/**"
       - "scripts/**"
       - "test/**"
+      - ".github/workflows/pr-test.yml"
   workflow_dispatch:
     inputs:
       version:
@@ -87,24 +89,6 @@ jobs:
           cd test/srt
           python3 run_suite.py --suite per-commit-2-gpu
 
-  unit-test-backend-8-gpu:
-    if: (github.repository == 'sgl-project/sglang' || github.event_name == 'pull_request') &&
-        github.event.pull_request.draft == false
-    runs-on: 8-gpu-runner
-    steps:
-      - name: Checkout code
-        uses: actions/checkout@v4
-
-      - name: Install dependencies
-        run: |
-          bash scripts/ci_install_dependency_8_gpu.sh
-
-      - name: Run test
-        timeout-minutes: 20
-        run: |
-          cd test/srt
-          python3 run_suite.py --suite per-commit-8-gpu
-
   performance-test-1-gpu-part-1:
     if: (github.repository == 'sgl-project/sglang' || github.event_name == 'pull_request') &&
         github.event.pull_request.draft == false
@@ -256,12 +240,35 @@ jobs:
           cd test/srt
           python3 test_moe_eval_accuracy_large.py
 
+  large-scale-test-8-gpu:
+    if: (github.repository == 'sgl-project/sglang' || github.event_name == 'pull_request') &&
+        github.event.pull_request.draft == false
+    needs: [
+      unit-test-frontend, unit-test-backend-1-gpu, unit-test-backend-2-gpu,
+      performance-test-1-gpu-part-1, performance-test-1-gpu-part-2, performance-test-2-gpu,
+      accuracy-test-1-gpu, accuracy-test-2-gpu,
+    ]
+    runs-on: 8-gpu-runner
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Install dependencies
+        run: |
+          bash scripts/ci_install_dependency_8_gpu.sh
+
+      - name: Run test
+        timeout-minutes: 25
+        run: |
+          cd test/srt
+          python3 run_suite.py --suite per-commit-8-gpu
+
   finish:
     if: always()
     needs: [
-      unit-test-frontend, unit-test-backend-1-gpu, unit-test-backend-2-gpu, unit-test-backend-8-gpu,
+      unit-test-frontend, unit-test-backend-1-gpu, unit-test-backend-2-gpu,
       performance-test-1-gpu-part-1, performance-test-1-gpu-part-2, performance-test-2-gpu,
-      accuracy-test-1-gpu, accuracy-test-2-gpu,
+      accuracy-test-1-gpu, accuracy-test-2-gpu, large-scale-test-8-gpu,
     ]
     runs-on: ubuntu-latest
     steps:
diff --git a/test/srt/test_pp_single_node.py b/test/srt/test_pp_single_node.py
index 4d0b4adac..b69659403 100644
--- a/test/srt/test_pp_single_node.py
+++ b/test/srt/test_pp_single_node.py
@@ -61,7 +61,7 @@ class TestPPAccuracy(unittest.TestCase):
         metrics = run_eval(args)
         print(f"{metrics=}")
 
-        self.assertGreater(metrics["accuracy"], 0.75)
+        self.assertGreater(metrics["accuracy"], 0.74)
         # Wait a little bit so that the memory check happens.
         time.sleep(5)