From 9a7e7a657644ffff7165b0c7a39033c934f6f63a Mon Sep 17 00:00:00 2001
From: Glen Liu <62917497+glenliu21@users.noreply.github.com>
Date: Thu, 9 Oct 2025 21:43:03 -0400
Subject: [PATCH] [Bug Fix] prevent lora adapter from being loaded into
 LoRAManager if it is already loaded (#11365)

---
 python/sglang/srt/lora/lora_manager.py |  9 +++++++++
 test/srt/lora/test_lora_update.py      | 26 ++++++++++++++++++++++++++
 2 files changed, 35 insertions(+)

diff --git a/python/sglang/srt/lora/lora_manager.py b/python/sglang/srt/lora/lora_manager.py
index ac6f26e5d..5247f2c58 100644
--- a/python/sglang/srt/lora/lora_manager.py
+++ b/python/sglang/srt/lora/lora_manager.py
@@ -156,6 +156,15 @@ class LoRAManager:
         Validate if an adapter can be loaded into the current LoRA memory pool and generate error if it is incompatible.
         """
 
+        # Check if this LoRA adapter is already loaded
+        if any(
+            lora_ref.lora_name == existing_lora_ref.lora_name
+            for existing_lora_ref in self.lora_refs.values()
+        ):
+            raise ValueError(
+                f"Failed to load LoRA adapter {lora_ref.lora_name} because it is already loaded"
+            )
+
         # Check if the LoRA adapter shape is compatible with the current LoRA memory pool configuration.
         memory_pool = getattr(self, "memory_pool", None)
         incompatible = memory_pool and not memory_pool.can_support(lora_config)
diff --git a/test/srt/lora/test_lora_update.py b/test/srt/lora/test_lora_update.py
index f2058f466..073100e17 100644
--- a/test/srt/lora/test_lora_update.py
+++ b/test/srt/lora/test_lora_update.py
@@ -101,6 +101,19 @@ BASIC_TESTS = [
             },
         ],
         op_sequence=[
+            Operation(
+                type=OperationType.LOAD,
+                data="philschmid/code-llama-3-1-8b-text-to-sql-lora",
+                expected_error="already loaded",
+            ),
+            Operation(
+                type=OperationType.UNLOAD,
+                data="philschmid/code-llama-3-1-8b-text-to-sql-lora",
+            ),
+            Operation(
+                type=OperationType.LOAD,
+                data="philschmid/code-llama-3-1-8b-text-to-sql-lora",
+            ),
             Operation(
                 type=OperationType.FORWARD,
                 data=create_batch_data(
@@ -224,6 +237,19 @@ BASIC_TESTS = [
                 type=OperationType.LOAD,
                 data="pbevan11/llama-3.1-8b-ocr-correction",
             ),
+            Operation(
+                type=OperationType.LOAD,
+                data="philschmid/code-llama-3-1-8b-text-to-sql-lora",
+                expected_error="already loaded",
+            ),
+            Operation(
+                type=OperationType.UNLOAD,
+                data="philschmid/code-llama-3-1-8b-text-to-sql-lora",
+            ),
+            Operation(
+                type=OperationType.LOAD,
+                data="philschmid/code-llama-3-1-8b-text-to-sql-lora",
+            ),
             Operation(
                 type=OperationType.FORWARD,
                 data=create_batch_data(