From 9a18aa54c2a8782399823fc132a3bcca93d19187 Mon Sep 17 00:00:00 2001 From: LukasBluebaum <38468743+LukasBluebaum@users.noreply.github.com> Date: Mon, 8 Sep 2025 19:47:19 +0200 Subject: [PATCH] [fix] Relax white space rules in EBNFComposer (#9595) --- .../sglang/srt/function_call/ebnf_composer.py | 20 ++++++----- .../srt/function_call/glm4_moe_detector.py | 2 +- .../srt/function_call/qwen3_coder_detector.py | 2 +- test/srt/test_function_call_parser.py | 34 +++++++++---------- 4 files changed, 30 insertions(+), 28 deletions(-) diff --git a/python/sglang/srt/function_call/ebnf_composer.py b/python/sglang/srt/function_call/ebnf_composer.py index d41968ea7..21b313982 100644 --- a/python/sglang/srt/function_call/ebnf_composer.py +++ b/python/sglang/srt/function_call/ebnf_composer.py @@ -50,19 +50,19 @@ class EBNFComposer: CALL_RULE_MAP = { "pythonic": 'call_{name} ::= "{name}" "(" {arguments_rule} ")"', - "json": 'call_{name} ::= "{{" "\\"name\\"" ":" "\\"{name}\\"" ", " "\\"arguments\\"" ":" {arguments_rule} "}}"', + "json": 'call_{name} ::= "{{" ws "\\"name\\"" ws ":" ws "\\"{name}\\"" ws "," ws "\\"arguments\\"" ws ":" ws {arguments_rule} ws "}}"', "xml": 'call_{name} ::= "\\n" {arguments_rule} "\\n"', } ARGUMENTS_RULE_MAP = { "pythonic": "{arg_rules}", - "json": '"{{" {arg_rules} "}}"', + "json": '"{{" ws {arg_rules} ws "}}"', "xml": "{arg_rules}", } KEY_VALUE_RULE_MAP = { "pythonic": '"{key}" "=" {valrule}', - "json": '"\\"{key}\\"" ":" {valrule}', + "json": '"\\"{key}\\"" ws ":" ws {valrule}', "xml": '"\\n" {valrule} "\\n"', } @@ -165,7 +165,7 @@ class EBNFComposer: tool_call_separator: Optional[str] = None, call_rule_fmt: Optional[str] = None, key_value_rule_fmt: Optional[str] = None, - key_value_separator: str = ",", + key_value_separator: str = 'ws "," ws', ): """ Generalized EBNF builder for all detectors. @@ -183,6 +183,10 @@ class EBNFComposer: key_value_rule_fmt: Optional custom format string for key-value pairs. It should define how each parameter is formatted, with placeholders {key} for the parameter name and {valrule} for the value rule. If None, a default format based on function_format will be used. + key_value_separator: Raw EBNF fragment inserted between key-value pairs. + This string is used verbatim (not auto-quoted). Pass: + - Quoted terminals when you need a literal token (e.g. '","' or '"\\n"'). + - Raw/non-terminals when you need grammar tokens (e.g. 'ws "," ws'). """ # ================================================================= # Step 1: Determine the root tool calls rule @@ -281,9 +285,7 @@ class EBNFComposer: # Add required properties joined by commas if required: rule_parts.append( - f' "{key_value_separator}" '.join( - prop_kv_pairs[k] for k in required - ) + f" {key_value_separator} ".join(prop_kv_pairs[k] for k in required) ) # Add optional properties with flexible ordering @@ -298,14 +300,14 @@ class EBNFComposer: opt_parts.append(prop_kv_pairs[optional[j]]) else: opt_parts.append( - f' ( "{key_value_separator}" {prop_kv_pairs[optional[j]]} )?' + f" ( {key_value_separator} {prop_kv_pairs[optional[j]]} )?" ) opt_alternatives.append("".join(opt_parts)) # Wrap with appropriate comma handling based on whether we have required properties if required: # Required properties exist, so optional group needs outer comma - rule_parts.append(f' ( "{key_value_separator}" ( ') + rule_parts.append(f" ( {key_value_separator} ( ") rule_parts.append(" | ".join(opt_alternatives)) rule_parts.append(" ) )?") else: diff --git a/python/sglang/srt/function_call/glm4_moe_detector.py b/python/sglang/srt/function_call/glm4_moe_detector.py index 39822fb19..6e89fe0a1 100644 --- a/python/sglang/srt/function_call/glm4_moe_detector.py +++ b/python/sglang/srt/function_call/glm4_moe_detector.py @@ -160,5 +160,5 @@ class Glm4MoeDetector(BaseFormatDetector): function_format="xml", call_rule_fmt='"{name}" "\\n" ( {arguments_rule} "\\n" )?', key_value_rule_fmt='"{key}" "\\n" "" {valrule} ""', - key_value_separator="\\n", + key_value_separator='"\\n"', ) diff --git a/python/sglang/srt/function_call/qwen3_coder_detector.py b/python/sglang/srt/function_call/qwen3_coder_detector.py index 454f5048e..9bd3c7c24 100644 --- a/python/sglang/srt/function_call/qwen3_coder_detector.py +++ b/python/sglang/srt/function_call/qwen3_coder_detector.py @@ -358,5 +358,5 @@ class Qwen3CoderDetector(BaseFormatDetector): function_format="xml", call_rule_fmt='"\\n" {arguments_rule} "\\n"', key_value_rule_fmt='"\\n" {valrule} "\\n"', - key_value_separator="\\n", + key_value_separator='"\\n"', ) diff --git a/test/srt/test_function_call_parser.py b/test/srt/test_function_call_parser.py index 0c8cabfa6..10003a4db 100644 --- a/test/srt/test_function_call_parser.py +++ b/test/srt/test_function_call_parser.py @@ -549,7 +549,7 @@ class TestEBNFGeneration(unittest.TestCase): # Check that the EBNF contains expected patterns self.assertIn("<｜tool▁calls▁begin｜>", ebnf) self.assertIn("<｜tool▁call▁begin｜>function<｜tool▁sep｜>get_weather", ebnf) - self.assertIn('\\"location\\"" ":" basic_string ', ebnf) + self.assertIn('\\"location\\"" ws ":" ws basic_string ', ebnf) # Validate that the EBNF can be compiled by GrammarCompiler try: @@ -591,8 +591,8 @@ class TestEBNFGeneration(unittest.TestCase): self.assertIsNotNone(ebnf) # Check that the EBNF contains expected patterns - self.assertIn('\\"name\\"" ":" "\\"get_weather\\"', ebnf) - self.assertIn('"\\"arguments\\"" ":"', ebnf) + self.assertIn('\\"name\\"" ws ":" ws "\\"get_weather\\"', ebnf) + self.assertIn('"\\"arguments\\"" ws ":"', ebnf) # Validate that the EBNF can be compiled by GrammarCompiler try: @@ -609,7 +609,7 @@ class TestEBNFGeneration(unittest.TestCase): # Check that the EBNF contains expected patterns self.assertIn('"[TOOL_CALLS] ["', ebnf) self.assertIn("call_get_weather | call_search", ebnf) - self.assertIn('"\\"arguments\\"" ":"', ebnf) + self.assertIn('"\\"arguments\\"" ws ":"', ebnf) # Validate that the EBNF can be compiled by GrammarCompiler try: @@ -625,8 +625,8 @@ class TestEBNFGeneration(unittest.TestCase): # Check that the EBNF contains expected patterns self.assertIn("", ebnf) - self.assertIn('\\"name\\"" ":" "\\"get_weather\\"', ebnf) - self.assertIn('"\\"arguments\\"" ":"', ebnf) + self.assertIn('\\"name\\"" ws ":" ws "\\"get_weather\\"', ebnf) + self.assertIn('"\\"arguments\\"" ws ":"', ebnf) # Validate that the EBNF can be compiled by GrammarCompiler try: @@ -724,13 +724,13 @@ class TestEBNFGeneration(unittest.TestCase): # Pythonic format: location="Paris" ( , ( unit=("celsius" | "fahrenheit") )? self.assertIn('"location" "=" basic_string', ebnf) # The comma should be inside the optional brackets for unit - self.assertIn('( "," ( "unit" "=" ', ebnf) + self.assertIn('( ws "," ws ( "unit" "=" ', ebnf) else: # JSON format: "location": "Paris" ( , ( "unit": ("celsius" | "fahrenheit") )? - self.assertIn('"location\\"" ":" basic_string', ebnf) + self.assertIn('"location\\"" ws ":" ws basic_string', ebnf) # The comma should be part of the optional group # This pattern ensures no trailing comma when unit is omitted - self.assertIn('( "," ( "\\"unit\\"" ":"', ebnf) + self.assertIn('( ws "," ws ( "\\"unit\\"" ws ":"', ebnf) # Validate that the EBNF can be compiled try: @@ -788,7 +788,7 @@ class TestEBNFGeneration(unittest.TestCase): ) # Check required field - self.assertIn('"required_field\\"" ":" basic_string', ebnf) + self.assertIn('"required_field\\"" ws ":" ws basic_string', ebnf) # Check the structure for optional parameters # The pattern should be: required_field ( "," ( opt1 ... | opt2 ... | opt3 ... ) )? @@ -797,16 +797,16 @@ class TestEBNFGeneration(unittest.TestCase): # Check that optional parameters are in a group with comma if args_rule: # Only check if args_rule was found self.assertIn( - '( ","', + '( ws "," ws (', args_rule, f"{name} should have comma grouped with optional parameters", ) # Check for the alternation pattern that allows flexible ordering # Should contain patterns like: opt1 ... | opt2 ... | opt3 - self.assertIn('"opt1\\"" ":" basic_number', args_rule) - self.assertIn('"opt2\\"" ":" basic_boolean', args_rule) - self.assertIn('"opt3\\"" ":" basic_string', args_rule) + self.assertIn('"opt1\\"" ws ":" ws basic_number', args_rule) + self.assertIn('"opt2\\"" ws ":" ws basic_boolean', args_rule) + self.assertIn('"opt3\\"" ws ":" ws basic_string', args_rule) # Check for alternation (|) which allows skipping optional parameters self.assertIn( @@ -881,9 +881,9 @@ class TestEBNFGeneration(unittest.TestCase): # This allows flexible ordering where any optional can appear first # Check the structure - self.assertIn('"opt1\\"" ":" basic_string', args_rule) - self.assertIn('"opt2\\"" ":" basic_number', args_rule) - self.assertIn('"opt3\\"" ":" basic_boolean', args_rule) + self.assertIn('"opt1\\"" ws ":" ws basic_string', args_rule) + self.assertIn('"opt2\\"" ws ":" ws basic_number', args_rule) + self.assertIn('"opt3\\"" ws ":" ws basic_boolean', args_rule) # The pattern SHOULD have alternation (|) for flexible ordering self.assertIn(