Improve bot release workflow (#11240)

2025-10-05 21:28:27 -07:00
parent 0cd1996eae
commit 8fd41eae93
7 changed files with 329 additions and 119 deletions
--- a/scripts/release/test_utils.py
+++ b/scripts/release/test_utils.py
@@ -0,0 +1,159 @@
+#!/usr/bin/env python3
+
+import unittest
+from pathlib import Path
+
+from utils import compare_versions, normalize_version, parse_version, validate_version
+
+
+class TestVersionUtils(unittest.TestCase):
+    def test_normalize_version(self):
+        """Test version normalization removes 'v' prefix."""
+        self.assertEqual(normalize_version("v0.5.3"), "0.5.3")
+        self.assertEqual(normalize_version("0.5.3"), "0.5.3")
+        self.assertEqual(normalize_version("v0.5.3rc0"), "0.5.3rc0")
+        self.assertEqual(normalize_version("0.5.3.post1"), "0.5.3.post1")
+
+    def test_validate_version(self):
+        """Test version format validation."""
+        # Valid formats
+        self.assertTrue(validate_version("0.5.3"))
+        self.assertTrue(validate_version("0.5.3rc0"))
+        self.assertTrue(validate_version("0.5.3rc1"))
+        self.assertTrue(validate_version("0.5.3rc999"))
+        self.assertTrue(validate_version("0.5.3.post1"))
+        self.assertTrue(validate_version("0.5.3.post10"))
+        self.assertTrue(validate_version("1.2.3"))
+        self.assertTrue(validate_version("10.20.30"))
+
+        # Invalid formats
+        self.assertFalse(validate_version("0.5"))
+        self.assertFalse(validate_version("0.5.3."))
+        self.assertFalse(validate_version("0.5.3rc"))
+        self.assertFalse(validate_version("0.5.3post1"))
+        self.assertFalse(validate_version("0.5.3-rc0"))
+        self.assertFalse(validate_version("v0.5.3"))
+        self.assertFalse(validate_version("0.5.3beta1"))
+        self.assertFalse(validate_version("0.5.3.rc0"))
+
+    def test_parse_version_stable(self):
+        """Test parsing stable version."""
+        self.assertEqual(parse_version("0.5.3"), (0, 5, 3, 0, 0))
+        self.assertEqual(parse_version("1.2.3"), (1, 2, 3, 0, 0))
+        self.assertEqual(parse_version("10.20.30"), (10, 20, 30, 0, 0))
+
+    def test_parse_version_rc(self):
+        """Test parsing release candidate versions."""
+        self.assertEqual(parse_version("0.5.3rc0"), (0, 5, 3, -1000, 0))
+        self.assertEqual(parse_version("0.5.3rc1"), (0, 5, 3, -999, 0))
+        self.assertEqual(parse_version("0.5.3rc2"), (0, 5, 3, -998, 0))
+        self.assertEqual(parse_version("0.5.3rc10"), (0, 5, 3, -990, 0))
+
+    def test_parse_version_post(self):
+        """Test parsing post-release versions."""
+        self.assertEqual(parse_version("0.5.3.post1"), (0, 5, 3, 0, 1))
+        self.assertEqual(parse_version("0.5.3.post2"), (0, 5, 3, 0, 2))
+        self.assertEqual(parse_version("0.5.3.post10"), (0, 5, 3, 0, 10))
+
+    def test_parse_version_invalid(self):
+        """Test parsing invalid versions raises error."""
+        with self.assertRaises(ValueError):
+            parse_version("0.5")
+        with self.assertRaises(ValueError):
+            parse_version("invalid")
+        with self.assertRaises(ValueError):
+            parse_version("v0.5.3")
+
+    def test_compare_versions_equal(self):
+        """Test comparing equal versions."""
+        self.assertEqual(compare_versions("0.5.3", "0.5.3"), 0)
+        self.assertEqual(compare_versions("0.5.3rc0", "0.5.3rc0"), 0)
+        self.assertEqual(compare_versions("0.5.3.post1", "0.5.3.post1"), 0)
+
+    def test_compare_versions_rc_ordering(self):
+        """Test release candidate ordering: rc0 < rc1 < rc2 < stable."""
+        # rc0 < rc1
+        self.assertEqual(compare_versions("0.5.3rc0", "0.5.3rc1"), -1)
+        self.assertEqual(compare_versions("0.5.3rc1", "0.5.3rc0"), 1)
+
+        # rc1 < rc2
+        self.assertEqual(compare_versions("0.5.3rc1", "0.5.3rc2"), -1)
+        self.assertEqual(compare_versions("0.5.3rc2", "0.5.3rc1"), 1)
+
+        # rc < stable
+        self.assertEqual(compare_versions("0.5.3rc0", "0.5.3"), -1)
+        self.assertEqual(compare_versions("0.5.3rc1", "0.5.3"), -1)
+        self.assertEqual(compare_versions("0.5.3", "0.5.3rc0"), 1)
+
+    def test_compare_versions_post_ordering(self):
+        """Test post-release ordering: stable < post1 < post2."""
+        # stable < post1
+        self.assertEqual(compare_versions("0.5.3", "0.5.3.post1"), -1)
+        self.assertEqual(compare_versions("0.5.3.post1", "0.5.3"), 1)
+
+        # post1 < post2
+        self.assertEqual(compare_versions("0.5.3.post1", "0.5.3.post2"), -1)
+        self.assertEqual(compare_versions("0.5.3.post2", "0.5.3.post1"), 1)
+
+    def test_compare_versions_full_ordering(self):
+        """Test complete version ordering: rc < stable < post."""
+        # rc < stable < post
+        self.assertEqual(compare_versions("0.5.3rc0", "0.5.3"), -1)
+        self.assertEqual(compare_versions("0.5.3", "0.5.3.post1"), -1)
+        self.assertEqual(compare_versions("0.5.3rc0", "0.5.3.post1"), -1)
+
+        # Verify transitivity: rc0 < rc1 < stable < post1 < post2
+        versions = [
+            "0.5.3rc0",
+            "0.5.3rc1",
+            "0.5.3",
+            "0.5.3.post1",
+            "0.5.3.post2",
+        ]
+        for i in range(len(versions) - 1):
+            self.assertEqual(
+                compare_versions(versions[i], versions[i + 1]),
+                -1,
+                f"{versions[i]} should be less than {versions[i + 1]}",
+            )
+
+    def test_compare_versions_different_patch(self):
+        """Test comparing versions with different patch numbers."""
+        # 0.5.3 < 0.5.4
+        self.assertEqual(compare_versions("0.5.3", "0.5.4"), -1)
+        self.assertEqual(compare_versions("0.5.4", "0.5.3"), 1)
+
+        # rc of higher patch > stable of lower patch
+        self.assertEqual(compare_versions("0.5.4rc0", "0.5.3"), 1)
+        self.assertEqual(compare_versions("0.5.3.post1", "0.5.4rc0"), -1)
+
+    def test_compare_versions_different_minor(self):
+        """Test comparing versions with different minor numbers."""
+        self.assertEqual(compare_versions("0.4.9", "0.5.0"), -1)
+        self.assertEqual(compare_versions("0.5.0", "0.4.9"), 1)
+
+    def test_compare_versions_different_major(self):
+        """Test comparing versions with different major numbers."""
+        self.assertEqual(compare_versions("0.9.9", "1.0.0"), -1)
+        self.assertEqual(compare_versions("1.0.0", "0.9.9"), 1)
+
+    def test_real_world_scenarios(self):
+        """Test real-world version bump scenarios."""
+        # Scenario 1: RC progression
+        self.assertEqual(compare_versions("0.5.3rc0", "0.5.3rc1"), -1)
+
+        # Scenario 2: RC to stable release
+        self.assertEqual(compare_versions("0.5.3rc2", "0.5.3"), -1)
+
+        # Scenario 3: Stable to post-release hotfix
+        self.assertEqual(compare_versions("0.5.3", "0.5.3.post1"), -1)
+
+        # Scenario 4: Post-release to next RC
+        self.assertEqual(compare_versions("0.5.3.post1", "0.5.4rc0"), -1)
+
+        # Scenario 5: Next stable version
+        self.assertEqual(compare_versions("0.5.3", "0.5.4"), -1)
+
+
+if __name__ == "__main__":
+    unittest.main()