Support Flatten Tensor Update Weights to speed up MOE Update Weights by 20% (#8079)

This commit is contained in:
Stefan He
2025-08-10 16:08:59 -07:00
committed by GitHub
parent 0418b9d4ea
commit 8ecf6b9d24
4 changed files with 210 additions and 3 deletions

View File

@@ -0,0 +1,106 @@
from dataclasses import dataclass
from typing import List, Tuple
import torch
@dataclass
class FlattenedTensorMetadata:
"""Metadata for a tensor in a flattened bucket"""
name: str
shape: torch.Size
dtype: torch.dtype
start_idx: int
end_idx: int
numel: int
class FlattenedTensorBucket:
"""
A bucket that flattens multiple tensors into a single tensor for efficient processing
while preserving all metadata needed for reconstruction.
"""
def __init__(
self,
named_tensors: List[Tuple[str, torch.Tensor]] = None,
flattened_tensor: torch.Tensor = None,
metadata: List[FlattenedTensorMetadata] = None,
):
"""
Initialize a tensor bucket from a list of named tensors OR from pre-flattened data.
Args:
named_tensors: List of (name, tensor) tuples (for creating new bucket)
flattened_tensor: Pre-flattened tensor (for reconstruction)
metadata: Pre-computed metadata (for reconstruction)
"""
if named_tensors is not None:
# Create bucket from named tensors
self.metadata: List[FlattenedTensorMetadata] = [None] * len(named_tensors)
self.flattened_tensor: torch.Tensor = None
if not named_tensors:
raise ValueError("Cannot create empty tensor bucket")
# Collect metadata and flatten tensors
current_idx = 0
flattened_tensors: List[torch.Tensor] = [None] * len(named_tensors)
for i, (name, tensor) in enumerate(named_tensors):
flattened = tensor.flatten()
flattened_tensors[i] = flattened
# Store metadata
numel = flattened.numel()
metadata_obj = FlattenedTensorMetadata(
name=name,
shape=tensor.shape,
dtype=tensor.dtype,
start_idx=current_idx,
end_idx=current_idx + numel,
numel=numel,
)
self.metadata[i] = metadata_obj
current_idx += numel
# Concatenate all flattened tensors
self.flattened_tensor = torch.cat(flattened_tensors, dim=0)
else:
# Initialize from pre-flattened data
if flattened_tensor is None or metadata is None:
raise ValueError(
"Must provide either named_tensors or both flattened_tensor and metadata"
)
self.flattened_tensor = flattened_tensor
self.metadata = metadata
def get_flattened_tensor(self) -> torch.Tensor:
"""Get the flattened tensor containing all bucket tensors"""
return self.flattened_tensor
def get_metadata(self) -> List[FlattenedTensorMetadata]:
"""Get metadata for all tensors in the bucket"""
return self.metadata
def reconstruct_tensors(self) -> List[Tuple[str, torch.Tensor]]:
"""
Reconstruct original tensors from flattened tensor with optimized performance.
Uses memory-efficient operations to minimize allocations and copies.
"""
# preallocate the result list
reconstructed = [None] * len(self.metadata)
for i, meta in enumerate(self.metadata):
tensor = self.flattened_tensor[meta.start_idx : meta.end_idx].reshape(
meta.shape
)
# batch dtype conversion (if needed)
if tensor.dtype != meta.dtype:
tensor = tensor.to(meta.dtype)
reconstructed[i] = (meta.name, tensor)
return reconstructed