From 7c347259ff2c72937a6669a1e2e33ba7d1ee7501 Mon Sep 17 00:00:00 2001 From: Zilin Zhu Date: Wed, 21 May 2025 16:58:55 +0800 Subject: [PATCH] [RL] allow weight updation with dp attention enabled (#6311) --- python/sglang/srt/managers/tokenizer_manager.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/python/sglang/srt/managers/tokenizer_manager.py b/python/sglang/srt/managers/tokenizer_manager.py index 5e6cf242a..8af7bf0f8 100644 --- a/python/sglang/srt/managers/tokenizer_manager.py +++ b/python/sglang/srt/managers/tokenizer_manager.py @@ -893,8 +893,8 @@ class TokenizerManager: ) -> Tuple[bool, str]: self.auto_create_handle_loop() assert ( - self.server_args.dp_size == 1 - ), "dp_size must be 1 for update weights from distributed" + self.server_args.dp_size == 1 or self.server_args.enable_dp_attention + ), "dp_size must be 1 or dp attention must be enabled for update weights from distributed" # This means that weight sync # cannot run while requests are in progress. @@ -909,8 +909,8 @@ class TokenizerManager: ) -> Tuple[bool, str]: self.auto_create_handle_loop() assert ( - self.server_args.dp_size == 1 - ), "dp_size must be 1 for update weights from distributed" + self.server_args.dp_size == 1 or self.server_args.enable_dp_attention + ), "dp_size must be 1 or dp attention must be enabled for update weights from tensor" # This means that weight sync # cannot run while requests are in progress.