EngineX-Hygon/sglang
5
0
Fork 0
Code Issues Pull Requests Actions 7 Projects Releases Wiki Activity

[minor] clean up docs and eos id (#2622)

Browse Source
This commit is contained in:
Lianmin Zheng
2024-12-27 11:23:46 -08:00
committed by GitHub
parent 7a7ac6bea1
commit 751e5ca273
3 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/references/contributor_guide.md
View File

@@ -19,4 +19,4 @@ Add unit tests under [sglang/test](https://github.com/sgl-project/sglang/tree/ma
## For Newcomers ## For Newcomers
If you want to contribute or learn but don't have a concrete idea yet, you can pick a task labeled as "good first issue" or "help wanted" from the list below. If you want to contribute or learn but don't have a concrete idea yet, you can pick a task labeled as "good first issue" or "help wanted" from the list below.
https://github.com/sgl-project/sglang/issues?q=is%3Aissue+label%3A%22good+first+issue%22%2C%22help+wanted%22 [https://github.com/sgl-project/sglang/issues?q=is%3Aissue+label%3A%22good+first+issue%22%2C%22help+wanted%22](https://github.com/sgl-project/sglang/issues?q=is%3Aissue+label%3A%22good+first+issue%22%2C%22help+wanted%22)

6
python/sglang/srt/configs/model_config.py
View File

@@ -15,7 +15,6 @@
import json import json
import logging import logging
from enum import IntEnum, auto from enum import IntEnum, auto
from functools import lru_cache
from typing import List, Optional, Set, Union from typing import List, Optional, Set, Union
import torch import torch
@@ -48,6 +47,7 @@ class ModelConfig:
self.model_path = model_path self.model_path = model_path
self.revision = revision self.revision = revision
self.quantization = quantization self.quantization = quantization
# Parse args # Parse args
self.model_override_args = json.loads(model_override_args) self.model_override_args = json.loads(model_override_args)
self.hf_config = get_config( self.hf_config = get_config(
@@ -131,6 +131,9 @@ class ModelConfig:
# Veirfy quantization # Veirfy quantization
self._verify_quantization() self._verify_quantization()
# Text attrs
self.hf_eos_token_id = self.get_hf_eos_token_id()
# Multimodel attrs # Multimodel attrs
self.image_token_id = getattr(self.hf_config, "image_token_id", None) self.image_token_id = getattr(self.hf_config, "image_token_id", None)
@@ -272,7 +275,6 @@ class ModelConfig:
self.quantization, self.quantization,
) )
@lru_cache()
def get_hf_eos_token_id(self) -> Optional[Set[int]]: def get_hf_eos_token_id(self) -> Optional[Set[int]]:
eos_ids = getattr(self.hf_config, "eos_token_id", None) eos_ids = getattr(self.hf_config, "eos_token_id", None)
if eos_ids: if eos_ids:

2
python/sglang/srt/managers/scheduler.py
View File

@@ -517,7 +517,7 @@ class Scheduler:
stream=recv_req.stream, stream=recv_req.stream,
lora_path=recv_req.lora_path, lora_path=recv_req.lora_path,
input_embeds=recv_req.input_embeds, input_embeds=recv_req.input_embeds,
eos_token_ids=self.model_config.get_hf_eos_token_id(), eos_token_ids=self.model_config.hf_eos_token_id,
) )
req.tokenizer = self.tokenizer req.tokenizer = self.tokenizer