From 2a936a841ec1e7f3a3a2d9cb90e09fbc1f683915 Mon Sep 17 00:00:00 2001 From: Hubert Lu <55214931+hubertlu-tw@users.noreply.github.com> Date: Thu, 8 May 2025 13:46:58 -0700 Subject: [PATCH] [AMD] switch to custom allreduce regardless of MSCCL setting on ROCm (#6097) --- .../device_communicators/custom_all_reduce.py | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/python/sglang/srt/distributed/device_communicators/custom_all_reduce.py b/python/sglang/srt/distributed/device_communicators/custom_all_reduce.py index 51bcd4722..9faff648c 100644 --- a/python/sglang/srt/distributed/device_communicators/custom_all_reduce.py +++ b/python/sglang/srt/distributed/device_communicators/custom_all_reduce.py @@ -296,7 +296,6 @@ class CustomAllreduce: self.meta, self.rank_data, handles, offsets, rank, self.full_nvlink ) self.register_buffer(self.buffer) - self.MSCCL = os.getenv("RCCL_MSCCL_ENABLE", "1") == "1" self.disabled = False @@ -430,13 +429,7 @@ class CustomAllreduce: if _is_hip: if self.full_nvlink: - if self.world_size == 8: - if self.MSCCL: - return False - else: - return inp_size < self.max_size - else: - return inp_size < self.max_size + return inp_size < self.max_size return False return False