[BugFix] Fix crash when receive a req with structed output in DP attention mode. (#3841)
This commit is contained in:
@@ -1154,6 +1154,10 @@ class Scheduler:
|
||||
elif batch.forward_mode.is_idle():
|
||||
if self.enable_overlap:
|
||||
self.tp_worker.resolve_batch_result(result.bid)
|
||||
if batch.next_batch_sampling_info:
|
||||
batch.next_batch_sampling_info.update_regex_vocab_mask()
|
||||
self.current_stream.synchronize()
|
||||
batch.next_batch_sampling_info.sampling_info_done.set()
|
||||
elif batch.forward_mode.is_dummy_first():
|
||||
batch.next_batch_sampling_info.update_regex_vocab_mask()
|
||||
self.current_stream.synchronize()
|
||||
@@ -1630,16 +1634,34 @@ class Scheduler:
|
||||
except futures._base.TimeoutError:
|
||||
break
|
||||
|
||||
if self.tp_size > 1:
|
||||
# Sync across TP ranks to make sure they have the same number of ready requests
|
||||
tensor = torch.tensor(num_ready_reqs, dtype=torch.int32)
|
||||
torch.distributed.all_reduce(
|
||||
tensor, op=torch.distributed.ReduceOp.MAX, group=self.tp_cpu_group
|
||||
)
|
||||
num_ready_reqs_max = tensor.item()
|
||||
for i in range(num_ready_reqs, num_ready_reqs_max):
|
||||
self.grammar_queue[i].grammar = self.grammar_queue[i].grammar.result()
|
||||
num_ready_reqs = num_ready_reqs_max
|
||||
if self.server_args.enable_dp_attention:
|
||||
if self.attn_tp_size > 1:
|
||||
# Sync across attn TP ranks to make sure they have the same number of ready requests
|
||||
tensor = torch.tensor(num_ready_reqs, dtype=torch.int32)
|
||||
torch.distributed.all_reduce(
|
||||
tensor,
|
||||
op=torch.distributed.ReduceOp.MAX,
|
||||
group=self.attn_tp_cpu_group,
|
||||
)
|
||||
num_ready_reqs_max = tensor.item()
|
||||
for i in range(num_ready_reqs, num_ready_reqs_max):
|
||||
self.grammar_queue[i].grammar = self.grammar_queue[
|
||||
i
|
||||
].grammar.result()
|
||||
num_ready_reqs = num_ready_reqs_max
|
||||
else:
|
||||
if self.tp_size > 1:
|
||||
# Sync across TP ranks to make sure they have the same number of ready requests
|
||||
tensor = torch.tensor(num_ready_reqs, dtype=torch.int32)
|
||||
torch.distributed.all_reduce(
|
||||
tensor, op=torch.distributed.ReduceOp.MAX, group=self.tp_cpu_group
|
||||
)
|
||||
num_ready_reqs_max = tensor.item()
|
||||
for i in range(num_ready_reqs, num_ready_reqs_max):
|
||||
self.grammar_queue[i].grammar = self.grammar_queue[
|
||||
i
|
||||
].grammar.result()
|
||||
num_ready_reqs = num_ready_reqs_max
|
||||
|
||||
self.waiting_queue.extend(self.grammar_queue[:num_ready_reqs])
|
||||
self.grammar_queue = self.grammar_queue[num_ready_reqs:]
|
||||
|
||||
Reference in New Issue
Block a user